Skip to content

Add project column choice option on issue sidebar#30617

Closed
a1012112796 wants to merge 12 commits into
go-gitea:mainfrom
a1012112796:zzc/dev/sidebar_board_option
Closed

Add project column choice option on issue sidebar#30617
a1012112796 wants to merge 12 commits into
go-gitea:mainfrom
a1012112796:zzc/dev/sidebar_board_option

Conversation

@a1012112796

Copy link
Copy Markdown
Member

example:
 test

Signed-off-by: a1012112796 <1012112796@qq.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 20, 2024
Signed-off-by: a1012112796 <1012112796@qq.com>
@lunny lunny added this to the 1.23.0 milestone Apr 22, 2024
@lunny

lunny commented Apr 23, 2024

Copy link
Copy Markdown
Member

A change comment need to be created when switching successfully.

Comment thread models/project/board.go Outdated
Comment thread models/project/issue.go Outdated
Comment thread routers/web/repo/issue.go
@a1012112796

Copy link
Copy Markdown
Member Author

A change comment need to be created when switching successfully.

That's another feature which is out of the topic of current pull request...

Signed-off-by: a1012112796 <1012112796@qq.com>
@lunny

lunny commented Apr 23, 2024

Copy link
Copy Markdown
Member

A change comment need to be created when switching successfully.

That's another feature which is out of the topic of current pull request...

No, I don't think so. It should be created with the same database transaction.

@a1012112796

Copy link
Copy Markdown
Member Author

A change comment need to be created when switching successfully.

That's another feature which is out of the topic of current pull request...

No, I don't think so. It should be created with the same database transaction.

see #30703, it's not a small change like what you see...

@yp05327

yp05327 commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

Considering multi project support, maybe using modal later is a good choice.

@lunny lunny mentioned this pull request May 7, 2024
13 tasks
@lunny

lunny commented May 28, 2024

Copy link
Copy Markdown
Member

Please resolve the conflicts, sorry the rename PR results in conflicts.

…_option

Signed-off-by: a1012112796 <1012112796@qq.com>
Signed-off-by: a1012112796 <1012112796@qq.com>
Signed-off-by: a1012112796 <1012112796@qq.com>
Comment thread routers/web/repo/projects.go Outdated
Comment thread web_src/js/features/repo-issue.js Outdated
Signed-off-by: a1012112796 <1012112796@qq.com>
Signed-off-by: a1012112796 <1012112796@qq.com>
@lunny lunny changed the title add project board choice option on issue sidebar Add project column choice option on issue sidebar Jun 3, 2024
Comment thread models/issues/issue_project.go
Comment thread models/project/column.go Outdated
Comment thread models/project/issue.go Outdated
}
defer committer.Close()

num, err := toColumn.NumIssues(ctx)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not right. If you update two columns, then they will have the same sorting.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but this function only can update one column.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean one by one.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean one by one.

I think it okay, becaue when call it one by one, NumIssues also will be canged one by one. else which sorting should be seted in this usage? zero?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks in moveIssuesToAnotherColumn(), it use max() sql function to get new sorting, I have use same logic in a824db0, how about this?

@yp05327

yp05327 commented Jun 6, 2024

Copy link
Copy Markdown
Contributor

Considering multi project support, maybe using modal later is a good choice.

Announce it again. This PR may cause big conflict in Web UI with #30381.

@yp05327

yp05327 commented Sep 19, 2024

Copy link
Copy Markdown
Contributor

Fix #13520?

@lunny lunny modified the milestones: 1.23.0, 1.24.0 Oct 10, 2024
@lunny lunny mentioned this pull request Dec 18, 2024
@wxiaoguang wxiaoguang removed this from the 1.24.0 milestone Apr 13, 2025
@wxiaoguang

Copy link
Copy Markdown
Contributor

This feature is exclusive to "Add support multiple projects again #30381", 30381 has multiple projects binding and there is no dedicated project column.

Only one PR could continue while both of the PRs have numbers of up-voting users. Need to decide. @go-gitea/maintainers

@wxiaoguang wxiaoguang added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Apr 19, 2025
@lunny

lunny commented Apr 19, 2025

Copy link
Copy Markdown
Member

Maybe we can close this one at the moment to follow what GH did.

@wxiaoguang

Copy link
Copy Markdown
Contributor

I also agree with that "support multiple projects" seems more intuitive to end users

@wxiaoguang wxiaoguang closed this Apr 20, 2025
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. topic/projects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants